feat(chat): implement file upload ingestion support #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add to to support handling file uploads - Add endpoint to - Add method to TypeScript - Add file upload button to component - Add example - Add unit tests for upload functionality
Contributor
|
Code Coverage SummaryDetailsDiff against mainResults for commit: de7aa84 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
MichaelMcCulloch-deepsense-ai
requested review from
dazy-ds,
jakubduda-dsai and
mhordynski
and removed request for
jakubduda-dsai and
mhordynski
dazy-ds
requested changes
Jan 20, 2026
typescript/ui/src/core/components/inputs/PromptInput/PromptInput.tsx
Outdated
Show resolved
Hide resolved
mkoruszowic
reviewed
Jan 20, 2026
dazy-ds
requested changes
Jan 23, 2026
Comment on lines
+137
to
+151
| if (body instanceof FormData) { | ||
| requestOptions.body = body | ||
| // Let the browser set the Content-Type header with the boundary | ||
| if ( | ||
| requestOptions.headers && | ||
| 'Content-Type' in requestOptions.headers | ||
| ) { | ||
| delete (requestOptions.headers as Record<string, string>)[ | ||
| 'Content-Type' | ||
| ] | ||
| } | ||
| } else { | ||
| requestOptions.body = | ||
| typeof body === 'string' ? body : JSON.stringify(body) | ||
| } |
Collaborator
There was a problem hiding this comment.
I've performed some tests and the current implementation doesn't seem to work. We are passing empty requestOptions.headers object to the _makeRequest method, which applies default headers. The default headers aren't overridden because requestOptions.headers field doesn't contain any Content-Type definition.
I think we should set default headers in the _makeRequest conditionally. Something like:
const defaultHeaders: Record<string, string> =
typeof options.body === 'string' // we guess that it's JSON
? {
'Content-Type': 'application/json',
}
: {}and also keep this part here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload_handlertoChatInterfaceto support handling file uploads/api/uploadendpoint toRagbitsAPIuploadFilemethod to TypeScriptRagbitsClientPromptInputcomponentexamples/chat/upload_chat.py